Allow plugins to be installed from URL

[mayurvaid-redvest]

• This would help in custom plugin or secured environments for eg: may be pulling from artifactory
• Also allow to pull latest as well

[mayurvaid-redvest]

@pb82 , Can you please review

[mayurvaid-redvest]

@pb82 @NissesSenap Can you please review

[NissesSenap]

@mayurvaid-redvest my initial look I think it looks okay. But there are a few to many splits for my brain right now.
Could you write a small test just to show that everything works as intended?

Using the existing use case and your new functionality.

[mayurvaid-redvest]

@NissesSenap , Thanks for reviewing this . Have added the test case Please let me know if anything else is required

[mayurvaid-redvest]

@NissesSenap , Please let me know updates on this ...Appreciate your help !!

[NissesSenap]

So I gave it a try on my client.

You need to use OS = os.environ.get("OS", platform.system().lower()) or something similar in your tests. Else the tests won't work on any client.

Since I'm a happy Linux user I get.

FAIL: test_get_plugin_withurl_multiple_withoutversion_reverse (plugins_test.TestGetPlugins)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/edvin/go/src/github.com/NissesSenap/grafana-plugin/plugins_test.py", line 136, in test_get_plugin_withurl_multiple_withoutversion_reverse
    self.assertEqual(actual, expected)
AssertionError: Lists differ: [('ht[73 chars]d?os=linux&arch=x86_64', '/tmp/grafana-clock-p[102 chars]ip')] != [('ht[73 chars]d?os=darwin&arch=x86_64', '/tmp/grafana-clock-[103 chars]ip')]

First differing element 0:
('htt[72 chars]d?os=linux&arch=x86_64', '/tmp/grafana-clock-panel_latest.zip')
('htt[72 chars]d?os=darwin&arch=x86_64', '/tmp/grafana-clock-[13 chars]zip')

- [('https://grafana.com/api/plugins/grafana-clock-panel/versions/latest/download?os=linux&arch=x86_64',
?                                                                                    ^  --

+ [('https://grafana.com/api/plugins/grafana-clock-panel/versions/latest/download?os=darwin&arch=x86_64',
?                                                                                    ^^^^

    '/tmp/grafana-clock-panel_latest.zip'),
   ('https://grafana.com/api/plugins/grafana-clock-panel',
    '/tmp/grafana-clock-panel.zip')]

----------------------------------------------------------------------

Since you have written your change in the master branch I don't have access to update the PR for you.

[NissesSenap]

Thanks for the tests btw, it really makes it easier to verify that everything looks okay :)

[mayurvaid-redvest]

So I gave it a try on my client.

You need to use OS = os.environ.get("OS", platform.system().lower()) or something similar in your tests. Else the tests won't work on any client.

Since I'm a happy Linux user I get.

FAIL: test_get_plugin_withurl_multiple_withoutversion_reverse (plugins_test.TestGetPlugins)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/edvin/go/src/github.com/NissesSenap/grafana-plugin/plugins_test.py", line 136, in test_get_plugin_withurl_multiple_withoutversion_reverse
    self.assertEqual(actual, expected)
AssertionError: Lists differ: [('ht[73 chars]d?os=linux&arch=x86_64', '/tmp/grafana-clock-p[102 chars]ip')] != [('ht[73 chars]d?os=darwin&arch=x86_64', '/tmp/grafana-clock-[103 chars]ip')]

First differing element 0:
('htt[72 chars]d?os=linux&arch=x86_64', '/tmp/grafana-clock-panel_latest.zip')
('htt[72 chars]d?os=darwin&arch=x86_64', '/tmp/grafana-clock-[13 chars]zip')

- [('https://grafana.com/api/plugins/grafana-clock-panel/versions/latest/download?os=linux&arch=x86_64',
?                                                                                    ^  --

+ [('https://grafana.com/api/plugins/grafana-clock-panel/versions/latest/download?os=darwin&arch=x86_64',
?                                                                                    ^^^^

    '/tmp/grafana-clock-panel_latest.zip'),
   ('https://grafana.com/api/plugins/grafana-clock-panel',
    '/tmp/grafana-clock-panel.zip')]

----------------------------------------------------------------------

Since you have written your change in the master branch I don't have access to update the PR for you.

Hey Thanks for this , Have updated it @NissesSenap .. Please validate