🐛: Target.GroupBy should be singular in the type declaration #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevitan
changed the title
kevitan
changed the title
GiedriusS
reviewed
Nov 1, 2021
panel.go
Outdated
| @@ -566,7 +566,7 @@ type Target struct { | |||
| CrossSeriesReducer string `json:"crossSeriesReducer,omitempty"` | |||
| PerSeriesAligner string `json:"perSeriesAligner,omitempty"` | |||
| ValueType string `json:"valueType,omitempty"` | |||
| GroupBys []string `json:"groupBys,omitempty"` | |||
| GroupBy []string `json:"groupBys,omitempty"` | |||
There was a problem hiding this comment.
Doesn't this need to be:
Suggested change
| GroupBy []string `json:"groupBys,omitempty"` | |
| GroupBy []string `json:"groupBy,omitempty"` |
? At least that's what you say in the PR description if I understood you correctly 🤔
There was a problem hiding this comment.
yes, that's exactly it. I knew I missed a spot somewhere. I've addressed that now.
K-Phoen
added a commit
to K-Phoen/sdk
that referenced
this pull request
Nov 19, 2021
…rafana-tools#180)" This reverts commit 6856e18.
wurbanski
pushed a commit
to kubermatic/grafanasdk
that referenced
this pull request
Mar 30, 2022
…-tools#180) * GroupBy should be singular in the JSON * fix json declaration for groupBy Co-authored-by: Tank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Grafana 8.0.5:
Before, I was using the
Target.GroupBysproperty, but it turns out that that did not have any effect. By examining other dashboards manually created, I noticed that the JSON for the Panels actually hadgroupbyin the singular. By changing the panel json for panels created by the grafana sdk and applying it, I was able to get the desired functionality.With the plural:
and with the singular:
the name of the cluster is redacted because it does display correctly.
this should restore the groupby functionality in the grafana-sdk. I did a search to see if the
GroupBysproperty was ever used, and I don't see any evidence of it in the documentation.