Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change data type #23

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Change data type #23

merged 3 commits into from
Sep 5, 2018

Conversation

IndraGunawan
Copy link
Contributor

@IndraGunawan IndraGunawan commented Sep 4, 2018 •
edited
Loading

  • change data type of Gauge.MaxValue and Gauge.MinValue to supports decimal number
  • change data type of Axis.Max and Axis.Min to supports value like 1e10
  • change data type of Panel.MaxDataPoints from int to IntString

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 22.505% when pulling b960f4c on bukalapak:change-datatype into 9f33c0d on grafana-tools:master.

@grafov grafov self-requested a review September 5, 2018 14:55
@grafov grafov merged commit a92fae1 into grafana-tools:master Sep 5, 2018
@grafov
Copy link
Member

grafov commented Sep 5, 2018

@IndraGunawan thank you for the contribution!

@IndraGunawan IndraGunawan deleted the change-datatype branch September 5, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafov grafov grafov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IndraGunawan @coveralls @grafov