Increase the limit of users returned #46
Conversation
As per documentation, `/api/users` returns only the first 1000 users. This means, that for Grafana instances that have more than 1000 users, this SDK function does not return all users. One option could be introducing a parameter, for `GetAllUsers()`, but that would be a breaking change for all existing users. As an alternative, I suggest setting the limit to a very high number (`99999`, in this case). This would avoid a breaking change and would make `GetAllUsers()` to work as expected (since the name implies it returns ALL users).
|
Did you test it with the value set to 99999? Well for the current case with See #47 for another proposed solution. |
|
Hi, Thanks for looking into it. I did test it out with I agree with the proposed cleanup. Yet, if we could still merge this change (just to have current |
|
Sure, let move step by step. |
|
Merged, thank you @tdabasinskas. |
As per documentation,
/api/usersreturns only the first 1000 users. This means, that for Grafana instances that have more than 1000 users, this SDK function does not return all users.One option could be introducing a parameter, for
GetAllUsers(), but that would be a breaking change for all existing users. As an alternative, I suggest setting the limit to a very high number (99999, in this case). This would avoid a breaking change and would makeGetAllUsers()to work as expected (since the name implies it returns ALL users).