Support 1.12/1.11 & multiple Grafana versions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This notation is only supported from Go >=1.13.
Lets support the last two/three major versions at least.
`github.com/pkg/errors` is a well known library for wrapping errors. Use it instead of the `%w` verb in `fmt.Errorf` which was only added on Go 1.13. It provides the same exact features like `fmt.Errorf` although it is compatible with Go 1.12 as well.
GiedriusS
force-pushed
the
support_one_twelve
branch
from
c52dae2 to
f2be81f
Compare
GiedriusS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It comes from a request at #66 (comment). Doesn't take too much effort albeit it comes at the price of a dependency which allows us to handle error wrapping in a 1.11-1.13 compatible way.