Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set mutex and block profiling #6311

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Set mutex and block profiling #6311

merged 10 commits into from
Feb 5, 2024

Conversation

mattdurham
Copy link
Collaborator

PR Description

Which issue(s) this PR fixes

I am explicitly not listing the settings in the docs at this time, since we may figure out the default is good enough and can ignore using them.

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@mattdurham
Copy link
Collaborator Author

I ran this at 50% and default 0.1% and both gave me some data with a simple setup.

@mattdurham mattdurham marked this pull request as ready for review February 5, 2024 19:39
@mattdurham
Copy link
Collaborator Author

The only downside here is the inability to turn it off entirely, if we really wanted that then I can add a path for 0.

rfratto
rfratto requested changes Feb 5, 2024
View reviewed changes
cmd/internal/flowmode/cmd_run.go Outdated Show resolved Hide resolved
cmd/internal/flowmode/cmd_run.go Show resolved Hide resolved
cmd/internal/flowmode/cmd_run.go Show resolved Hide resolved
cmd/internal/flowmode/cmd_run.go Outdated Show resolved Hide resolved
cmd/internal/flowmode/cmd_run.go Outdated Show resolved Hide resolved
@rfratto
Copy link
Member

rfratto commented Feb 5, 2024

(To be clear, my "request changes" was only for my comment about SetBlockProfilingRate; everything else is a nit)

@mattdurham mattdurham requested a review from rfratto February 5, 2024 20:22
rfratto
rfratto approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we see that the impact of the defaults are more than we want, we might want to consider changing the defaults to align with Go (i.e., disabled by default). But we won't really know until we try so :shipit:

@mattdurham mattdurham enabled auto-merge (squash) February 5, 2024 20:25
@mattdurham mattdurham merged commit 0523960 into main Feb 5, 2024
10 checks passed
@mattdurham mattdurham deleted the set_mutex_and_block_profiling branch February 5, 2024 20:52
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@mattdurham @BarunKGP
Set mutex and block profiling (grafana#6311)
a1b32d1 
* Add some environment hooks and set a default to 00.1 percent.

* add changelog

* fix name in message

* always enable it even on failure to parse

* more cleanup

* fix lint

* Fix issue and naming

* add more context

* rename vars
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees

@rfratto rfratto

@erikbaranowski erikbaranowski

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattdurham @rfratto @erikbaranowski