Rework receivers status gathering to not need upstream changes. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
stevesg/implement-receivers-status-differently
branch
from
42f705d to
3694fcd
Compare
The Grafana version of the Alertmanager /api/v1/receivers API is extended to return information about the last notification attempt for each integration. This has been implemented as a change to the Prometheus Alertmanager fork. We would like to avoid divergence from upstream where possible. This change reworks the status gathering for receivers such that we do not need upstream changes. It instead works by wrapping the notify.Notifier interface for each integration, and capturing the necessary details. To make this as clean as possible, there are two drop-in replacements for Receiver and Integration, which wrap the upstream types plus the additional functionality. This means the code that uses these types can stay largely untouched.
stevesg
force-pushed
the
stevesg/implement-receivers-status-differently
branch
from
3694fcd to
05fee94
Compare
santihernandezc
deleted the
stevesg/implement-receivers-status-differently
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Grafana version of the Alertmanager /api/v1/receivers API is extended
to return information about the last notification attempt for each integration.
This has been implemented as a change to the Prometheus Alertmanager fork. We
would like to avoid divergence from upstream where possible.
This change reworks the status gathering for receivers such that we do not need
upstream changes. It instead works by wrapping the notify.Notifier interface
for each integration, and capturing the necessary details. To make this as
clean as possible, there are two drop-in replacements for Receiver and
Integration, which wrap the upstream types plus the additional functionality.
This means the code that uses these types can stay largely untouched.