Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a variable to override Kubernetes API service #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nberezhnoy
Copy link

This merge request introduces a new configuration variable, kubernetes_api_address, to override the default Kubernetes API server address. This is necessary because the Kubernetes API service name may differ in some installations, making it impossible to collect metrics.

Copy link
Collaborator

@bentonam bentonam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nberezhnoythank you for the contribution, this is a great idea! I would prefer that new arguments optional arguments that are added are added to the end of the argument list instead of at the top above other required arguments. Can you change the order of arguments in both he alloy module and documentation?

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Nberezhnoy Nberezhnoy requested a review from bentonam January 17, 2025 07:01
@Nberezhnoy
Copy link
Author

@bentonam hi, i updated the order of the arguments, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants