Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add task topic to migrate from Flow mode to Alloy #104

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 2, 2024

Thanks to @erikbaranowski for helping me think this one through :)

@rfratto rfratto requested a review from erikbaranowski April 2, 2024 19:42
@rfratto rfratto requested a review from clayton-cornell as a code owner April 2, 2024 19:42
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions

docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
docs/sources/tasks/migrate/from-flow.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Apr 2, 2024
- Set `--stability.level` to `experimental` if you are using any of the following components:
- [otelcol.receiver.vcenter]
- Otherwise, `--stability.level` may be omitted or set to the default value (`generally-available`).
- When installing on Kubernetes, update your `values.yaml` file to rename the `agent` key to `alloy`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the config sometimes exist in the values.yaml file? I'm not sure if you need or want to mention in the steps about that so someone doesn't quickly start up a duplicate config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be (agent.configMap.content / alloy.configMap.content), but I think this falls under the general "configure Alloy" instruction bucket. The user will have to refer back to other pages to learn how to configure Alloy for their specific platform.

@rfratto
Copy link
Member Author

rfratto commented Apr 2, 2024

@clayton-cornell Erik was worried someone would see this guide and get overwhelmed by the amount of content in it. He suggested finding a place to comment something along the lines of "if you don't care about downtime, just uninstall Flow and then install Alloy as a new binary."

Neither of us were quite sure how to phrase that so I left it out of the initial PR. What do you think? Should we try to include something about the "quicker" path here?

cc @erikbaranowski

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really nice! 🙌

I agree that we should include a sentence about a 'quick and dirty' migration. The intro section might be a good place for it IMHO.

@rfratto rfratto requested a review from clayton-cornell April 3, 2024 12:31
@rfratto
Copy link
Member Author

rfratto commented Apr 3, 2024

Added something at the top, but it probably needs a little TLC on the phrasing.

- Custom command-line flags configured in Grafana Agent Flow should be reflected in your {{< param "PRODUCT_NAME" >}} installation.
- {{< param "PRODUCT_NAME" >}} may need to be deployed with the `--stability.level` flag in [run] to enable non-stable components:
- Set `--stability.level` to `public-preview` if you are using any of these components:
- [discovery.process]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to explicitly call these out since this may change over time or is this laser focused on 0.40.x to alloy 1.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we could, two things come to mind though:

  1. It's unlikely we'll add new components after 0.40
  2. It would generally go against the idea of "timeless documentation" but if we think it's important enough we can probably bend that rule

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeless documentation is a guideline... and we bend it quite a bit across the Agent/Alloy docs (I am slowly weeding it out, but there will always be cases where time-based content important)

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell
Copy link
Contributor

Erik was worried someone would see this guide and get overwhelmed by the amount of content in it. He suggested finding a place to comment something along the lines of "if you don't care about downtime, just uninstall Flow and then install Alloy as a new binary."

Neither of us were quite sure how to phrase that so I left it out of the initial PR. What do you think? Should we try to include something about the "quicker" path here?

I missed this question. I see a note at the top of the topic explaining things. That is probably enough.

@rfratto rfratto merged commit 8318ede into main Apr 4, 2024
9 checks passed
@rfratto rfratto deleted the alloy-migration-guide branch April 4, 2024 16:46
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants