Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeout for informer on loki.source.podlogs #1862

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

elburnetto-intapp
Copy link
Contributor

@elburnetto-intapp elburnetto-intapp commented Oct 9, 2024

PR Description

This PR is to fix #1852 where on a busy Kubernetes cluster, the loki.source.podlogs component times-out after 10 seconds with error 'failed to configure informers: Timeout exceeded while configuring informers. Check the connection to the Kubernetes API is stable and that Alloy has appropriate RBAC permissions'.

Which issue(s) this PR fixes

Fixes #1852

Notes to the Reviewer

Similar issue was seen (#233) where the fix was to increase the timeout on the informer. I have validated this works on a busy K8s cluster and resolves the issue of the component not starting.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@elburnetto-intapp elburnetto-intapp requested a review from a team as a code owner October 9, 2024 19:51
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merged after unit test complete.

@mattdurham mattdurham merged commit ee9034b into grafana:main Oct 9, 2024
14 of 15 checks passed
pbailhache pushed a commit to pbailhache/alloy that referenced this pull request Oct 17, 2024
ptodev added a commit that referenced this pull request Oct 18, 2024
* Add v1.4.3 to the changelog

* [faro collector] add missing struct fields so that payload.meta.browser fields are not lost (#1824)

* Update payload.go

* Update CHANGELOG.md

* Update payload.go

* Update payload.go

* Update payload.json

* Update payload.json

* Update payload.json

* Update payload_test.go

* Update payload.json

* Remove Pyroscope scrape loops for no longer active targets (#1833)

* fix: increase timeout for informer on loki.source.podlogs (#1862)

* [prometheus.exporter.windows] Fix default values (#1878)

* Fix default values

* Wrap regexes

* Remove unnecessary comment

* Fix comment

* enabled_list in the smb block should be deprecated

* Fix docs and comments

* Apply suggestions from code review

Co-authored-by: Clayton Cornell <[email protected]>

* Replace "regex" with "regular expression"

* Update changelog

---------

Co-authored-by: Clayton Cornell <[email protected]>

* Fix changelog

* Change VERSION

---------

Co-authored-by: a <[email protected]>
Co-authored-by: Alex Burnett <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loki.source.podlogs fails to start due to timeout error on busy K8 clusters
3 participants