prometheus.exporter.windows - Convert sentence to note to make important detail stand out #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
dehaansa
approved these changes
Dec 6, 2024
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
clayton-cornell
commented
Dec 6, 2024
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
…er.windows.md Co-authored-by: Clayton Cornell <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ant detail stand out (#2220) * Convert sentence to note to make it stand out * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Sam DeHaan <[email protected]> (cherry picked from commit ac1fae4)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A Slack conversation came up about an important but often missed detail in the
prometheus.exporter.windowsdocumentation about*.promfiles. There is a mandatory empty CR/LF at the end of the*.promfiles that users often miss. Converted the sentence to a Note to make it stand out a little more.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist