Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: make it clear that non-root support is experimental #774

Merged
merged 1 commit into from
May 8, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented May 6, 2024

Users looking at the Dockerfile may not understand that non-root support is both undocumented and experimental. This commit makes that status explicit with a comment.

Users looking at the Dockerfile may not understand that non-root support
is both undocumented and experimental. This commit makes that status
explicit with a comment.
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit e703168 into grafana:main May 8, 2024
14 checks passed
@rfratto rfratto deleted the add-warning-dockerfile-nonroot branch May 8, 2024 12:50
github-actions bot pushed a commit that referenced this pull request May 8, 2024
Users looking at the Dockerfile may not understand that non-root support
is both undocumented and experimental. This commit makes that status
explicit with a comment.

(cherry picked from commit e703168)
rfratto added a commit that referenced this pull request May 8, 2024
#795)

Users looking at the Dockerfile may not understand that non-root support
is both undocumented and experimental. This commit makes that status
explicit with a comment.

(cherry picked from commit e703168)

Co-authored-by: Robert Fratto <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release/v1.1 backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants