Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates with latest snowflake prometheus exporter (fixes null issues) #939

Merged
merged 2 commits into from
May 29, 2024

Conversation

StefanKurek
Copy link
Contributor

PR Description

Updates to the newest Snowflake Prometheus Exporter (which contains a NULL value fix).

Which issue(s) this PR fixes

https://github.com/grafana/support-escalations/issues/10637

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @StefanKurek!

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the nit in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: William Dumont <[email protected]>
@wildum wildum merged commit 551d407 into grafana:main May 29, 2024
15 checks passed
rfratto pushed a commit to rfratto/alloy that referenced this pull request May 30, 2024
…grafana#939)

* updates with latest snowflake prometheus exporter (fixes null issues)

* Update CHANGELOG.md

Co-authored-by: William Dumont <[email protected]>

---------

Co-authored-by: William Dumont <[email protected]>
(cherry picked from commit 551d407)
rfratto added a commit that referenced this pull request May 30, 2024
* Fix panic when component ID contains `/` in `otelcomponent.MustNewType(ID)` (#858)

Signed-off-by: Weifeng Wang <[email protected]>
(cherry picked from commit 7bae89c)

* No error when http fails (#841)

* Fail if we see the port is not available

* Update changelog

* cleanup message

* Update CHANGELOG.md

Co-authored-by: Erik Baranowski <[email protected]>

---------

Co-authored-by: Erik Baranowski <[email protected]>
(cherry picked from commit 4ca3f84)

* fix panic loki source docker (#875)

(cherry picked from commit 4fb1df9)

* clustering: fix ipv6 advertise addresses (#869)

Signed-off-by: Matthew Penner <[email protected]>
(cherry picked from commit 3df2cd0)

* otelcol: decouple otel/alloy component IDs (#882)

Signed-off-by: Paschalis Tsilias <[email protected]>
(cherry picked from commit d018e6e)

* updates with latest snowflake prometheus exporter (fixes null issues) (#939)

* updates with latest snowflake prometheus exporter (fixes null issues)

* Update CHANGELOG.md

Co-authored-by: William Dumont <[email protected]>

---------

Co-authored-by: William Dumont <[email protected]>
(cherry picked from commit 551d407)

* feat(vcs): bubble up SSH key conversion error for better debugging experience (#943)

* feat(vcs): bubble up SSH key conversion error for better debugging experience

Signed-off-by: hainenber <[email protected]>

* chore: refactor code to be more succinct

Signed-off-by: hainenber <[email protected]>

---------

Signed-off-by: hainenber <[email protected]>
(cherry picked from commit 037893f)

* prepare changelog for 1.1.1 (#958)

This includes all bugfixes found in main to date except for #703, which
is a more involved change that should probably wait for a minor release.

(cherry picked from commit 3bceb1a)

---------

Co-authored-by: Weifeng Wang <[email protected]>
Co-authored-by: mattdurham <[email protected]>
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Matthew Penner <[email protected]>
Co-authored-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Stefan Kurek <[email protected]>
Co-authored-by: Đỗ Trọng Hải <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
@StefanKurek StefanKurek deleted the feat/snowflake-update branch February 4, 2025 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants