Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default loading #462

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix default loading #462

merged 1 commit into from
Sep 12, 2022

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Sep 12, 2022

Noticed that when creating a new query (with the new editor), this error appears:

Screenshot from 2022-09-12 11-54-15

It was because the default database was not being stored in the query object.

Ref: #391

@andresmgot andresmgot requested a review from a team as a code owner September 12, 2022 09:55
@github-actions
Copy link

Backend code coverage report for PR #462
No changes

@github-actions
Copy link

Frontend code coverage report for PR #462

Plugin Main PR Difference
src 79.06% 79.06% 0%

Copy link
Contributor

@yaelleC yaelleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@andresmgot andresmgot merged commit f640554 into main Sep 12, 2022
@andresmgot andresmgot deleted the defaultdb branch September 12, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants