Prevent usage of failed connections and improve connection management #1156
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamyeats
changed the title
db when PingContext returns an error
adamyeats
force-pushed
the
pool-defaults-ping-error
branch
from
3d78e3b to
03c123f
Compare
…g error is returned
adamyeats
force-pushed
the
pool-defaults-ping-error
branch
4 times, most recently
from
91d4d63 to
996b1b6
Compare
adamyeats
force-pushed
the
pool-defaults-ping-error
branch
from
996b1b6 to
a6b2b28
Compare
aangelisc
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
This LGTM! The only suggestion I would make is to have connection lifetime, max idle connections, and max open connections configurable as we do in other data sources. It'd be nice to do that in this PR but feel free to also do it later on.
I definitely think this change should explicitly be called out in the changelog with the previous defaults vs the current defaults. I'm wondering if it constitutes a breaking change but I'm not sure if anyone would be reliant on these settings. Wdyt?
SpencerTorres
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Always good to see this kind of async logic cleaned up 👍
I agree with @aangelisc, more configuration is nice, even if we don't write the frontend UI for it yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves connection management and error handling to ensure that failed connections are not returned to the pool, preventing the use of invalid connections.
PingContext(ctx)connections are not returned to the pool. IfPingContext(ctx)fails,dbis no longer returned to prevent an unusable connection from being used.context.WithTimeout) closer toPingContext(ctx). Prevents premature cancellations that could occur during connection setup.MaxOpenConnsto 50.MaxIdleConnsto 25.selectcheck was moved back to beforePingContext(ctx)to avoid connecting ifctx.Done()is already triggered. The error fromPingContext(ctx)is now handled outside of theselectasPingContext(ctx)is context aware.