-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow claims-like attribute keys #253
Conversation
|
One potential change for discussion is using something like '->' for the pathsep instead of '|' to reduce chances someone has it in existing attribute map keys. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
8741260
to
a4b2ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrabit
Thanks! 🙏
Motivation
The current use of
dictor
to dynamically fetch attribute keys usingpathsep='/'
interferes with commonly used url-like claim names, i.e.http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name
References:
Bumping mr @mostafa as per Contribution notes ;)