Introduce RingTokenGenerator configuration in LifecyclerConfig and BasicLifecyclerConfig #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
from
34dc50f to
877e53d
Compare
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
from
877e53d to
5502988
Compare
pracucci
reviewed
Jun 20, 2023
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
2 times, most recently
from
8d32573 to
4d259ed
Compare
…ifecyclerConfig Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
from
4d259ed to
d580f1c
Compare
duricanikolic
changed the title
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
from
b21d9db to
fea8923
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/spread-minimizier-tg
branch
from
4d6354e to
a4fd5e4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduces a
RingTokenGeneratorconfiguration inLifecyclerConfigandBasicLifecyclerConfig.RingTokenGenerator, if set, specifies theTokenGeneratorimplementation that will be used for token generation. Default value isnil, meaning thatRandomTokenGeneratoris used.Which issue(s) this PR fixes:
Part of grafana/mimir#4736
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]