Expose IngestersWithTokensCount and IngestersWithTokensInZone count from ring.ReadRing #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
approved these changes
Apr 11, 2024
pstibrany
approved these changes
Apr 11, 2024
| @@ -518,6 +518,18 @@ func (d *Desc) getOldestRegisteredTimestamp() int64 { | |||
| return result | |||
| } | |||
|
|
|||
| func (d *Desc) instancesWithTokensCount() int { | |||
| count := 0 | |||
| if d != nil { | |||
There was a problem hiding this comment.
super-nit: if d == nil we can return 0, and then reduce indentation in the following code.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds
InstancesWithTokensCountandInstancesWithTokensInZoneCountmethods to thering.ReadRinginterface and*ring.Ringimplementation. These methods provide global and per-zone counts of registered instances that have some tokens in the ring, regardless of instance state. In Mimir we need these to exclude instances with no tokens when calculating limits (since these instances won't actually handle a portion of the global limit).This PR also moves the
InstancesCountimplementation toring.go, with the other instance counting functions.Which issue(s) this PR fixes:
Relates to grafana/mimir#7847
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]