Refactor: Reconcile loggers, prepare for concurrent reconcilers #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
Baarsgaard
force-pushed
the
refactor_reconcile_loggers_prep_concurrent_reconciles
branch
from
eb0e9ca to
c2d45cb
Compare
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
refactor_reconcile_loggers_prep_concurrent_reconciles
branch
from
c2d45cb to
d7d80cf
Compare
|
I think this would be even cleaner by only passing the context and having the logger stored there |
Baarsgaard
force-pushed
the
refactor_reconcile_loggers_prep_concurrent_reconciles
branch
from
d7d80cf to
519c7fd
Compare
theSuess
requested changes
Jan 28, 2025
theSuess
approved these changes
Jan 29, 2025
Baarsgaard
deleted the
refactor_reconcile_loggers_prep_concurrent_reconciles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking to implement an option for configuring
MaxConcurrentReconcileswhen registering controllers.But realised that the Reconciler structs seem to be shared across reconcile requests, meaning
r.Logcould be replaced with context values from a later reconcileRequest.This is especially likely for
GrafanaContactPointsdue to theWatchesinGrafanaNotificationPolicy.Kubebuilder suggests using the plain
log := log.FromContext(ctx)Kubebuilder recommends to always have the ctx as the first argument and I have ensured that is the case as much as possible: kubebuilder controller-implementation