Fix: NotificationPolicy LoopDetected condition and route.receiver validation
#1843
+69
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: NotificationPolicyRoute missing category
chore: Move InvalidSpec loopDetection above Grafana instance fetching
github-actions
bot
added
documentation
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1837 on I was unable to provoke the
LoopDetectedstatus and discovered that it was removed immediately after being set, the detection itself seems to work without issues.The above resulted in loops being detected, dynamic routes being ignored and an
ApplySucceededcondition onGrafanaNotificationPolicyCRsThis means that previously working NotificationPolicy trees with dynamic routes would be overwritten with only the static routes in the main
GrafanaNotificationPolicy, if any.This changes the behaviour from applying only static routes and ignoring everything dynamic to refusing updates entirely.
LoopDetectedis now before fetching instances resulting in it having higher priority.InvalidSpecis an error and theNoMatchingInstancesis not.receiveris now a required field due to the current implementation always returning400 BAD REQUESTwhen trying to apply a route when the receiver is omitted.Lastly, the
grafana-operatorcategory was missing from theGrafanaNotificationPolicyRoute