Command palette: Enable folder searching #62663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
add to changelog
area/navigation
no-backport
ashharrison90
requested review from
joshhunt and
yaelleC
and removed request for
a team
ashharrison90
commented
Feb 1, 2023
| [dashboardResults] | ||
| () => | ||
| searchResults | ||
| .filter((item) => item.id.startsWith('go/dashboard')) |
There was a problem hiding this comment.
not sure whether it's worth adding an explicit new type property to our CommandPaletteAction? using the id feels a little brittle 🤔
There was a problem hiding this comment.
also could rewrite this into a generic for loop to avoid looping the array twice? lmk what you think
9 tasks
eledobleefe
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
I've tested it on my local and works 🎉, although you may want a review of someone with more context, like @joshhunt.
joshhunt
approved these changes
Feb 9, 2023
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
search folders as well as dashboards in the command palette
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: