Inspector: Show transformation query errors #73344
Conversation
| @@ -67,7 +67,7 @@ export const InspectErrorTab = ({ errors }: InspectErrorTabProps) => { | |||
| return ( | |||
| <> | |||
| {errors.map((error, index) => ( | |||
| <Alert title={error.refId || `Query ${index + 1}`} severity="error" key={index}> | |||
| <Alert title={error.refId || `Error ${index + 1}`} severity="error" key={index}> | |||
There was a problem hiding this comment.
changing the text here because the error has no relation to query index
| @@ -41,6 +41,10 @@ export const heatmapTransformer: SynchronousDataTransformerInfo<HeatmapTransform | |||
|
|
|||
| transformer: (options: HeatmapTransformerOptions) => { | |||
| return (data: DataFrame[]) => { | |||
| if (1 === 1) { | |||
| data[200].fields = []; // will throw an exception! | |||
There was a problem hiding this comment.
^^^ DO NOT MERGE... this just forces an error for testing
| const [dataOptions, setDataOptions] = useState<GetDataOptions>({ | ||
| withTransforms: false, | ||
| withTransforms: defaultTab === InspectTab.Error, |
There was a problem hiding this comment.
previously this would mask any xform errors since they are not run
There was a problem hiding this comment.
yea, working on the new inspector for scenes and I looked at this code and its very confusing that the data options that live under the Data tab can affect the data passed to other tabs. (Not doing that for scene inspect drawer)
| @@ -63,8 +63,10 @@ export const usePanelLatestData = ( | |||
|
|
|||
| return { | |||
| data: latestData, | |||
| error: latestData && latestData.error, | |||
There was a problem hiding this comment.
this was only checking the deprecated property... not the other flavors that will show alerts in the panel
| @@ -272,6 +272,8 @@ describe('PanelQueryRunner', () => { | |||
|
|
|||
| ctx.runner.getData({ withTransforms: true, withFieldConfig: true }).subscribe({ | |||
| next: (data: grafanaData.PanelData) => { | |||
| console.log('XFORM', data); | |||
There was a problem hiding this comment.
TODO... not yet sure how to test this :(
ryantxu
changed the title
ryantxu
added
no-backport
| @@ -228,7 +228,7 @@ export class PanelQueryRunner { | |||
| return of({ | |||
| ...data, | |||
| state: LoadingState.Error, | |||
| error: toDataQueryError(err), | |||
| errors: [toDataQueryError(err)], | |||
There was a problem hiding this comment.
this PR fixes the inspector so it also shows errors when the array is set... that is good because the single error flavor is deprecated in favor of using the array
public/app/features/dashboard/components/Inspector/InspectContent.tsx
Outdated
Show resolved
Hide resolved
| if (1 === 1) { | ||
| data[200].fields = []; // will throw an exception! | ||
| } | ||
|
|
There was a problem hiding this comment.
😬 - just want to make sure we remember to remove this before merging
| if (1 === 1) { | |
| data[200].fields = []; // will throw an exception! | |
| } |
What is this feature?
While working on #73451, I discovered that the inspect error tab will not show transformation errors
Why do we need this feature?
Currently when transforms have an error you can not see them in the inspector. With this PR they will now show up:
This is more important when multiple errors may exist and the inspector is the only way to know what happened