Frontend: Update to Eslint 9

[jackw]

What is this feature?

This PR updates the codebase to use Eslint 9.

Massive thanks to @ashharrison90 for the support/answering all my random questions. 🏅

Why do we need this feature?

So we stay up to date with dependencies and stop using a deprecated version of eslint.

Who is this feature for?

Grafana devs / contributors

Which issue(s) does this PR fix?:

Related: grafana/plugin-tools/issues/879

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[ashharrison90]

what's with the modifications to .go files? 🤔

[itsmylife]

what's with the modifications to .go files? 🤔

You don't need to specify the type again while you are defining the items in map. The type can be inferred from the variable definition. They are unnecessary. And somehow maybe eslint, or some other tool triggered a cleanup. So we have these changes.

[ashharrison90]

what's with the modifications to .go files? 🤔

You don't need to specify the type again while you are defining the items in map. The type can be inferred from the variable definition. They are unnecessary. And somehow maybe eslint, or some other tool triggered a cleanup. So we have these changes.

edit: i don't think it can be eslint... but i would like to know how it got here 😅

[itsmylife]

@ashharrison90 I agree that we should remove those .go changes from this PR. And yeah I'd like to know too :)

[jackw]

what's with the modifications to .go files? 🤔

A fine question! It appears to have happened when I merged main into this branch. 😕

[jackw]

what's with the modifications to .go files? 🤔

It's caused by the git hook backend-format and the merge of main. My IDE complains about it:

Switching to main and running gofmt -w -s pkg/services/authz/zanzana/common/info.go will also trigger it.

As there is no go format check in CI it will only surface when someone touches the file and uses the git hooks.

I've reverted them in 365c055. 👍

[ashharrison90]

lgtm 👍

[ashharrison90]

do we actually use this anywhere? 🤔

[jackw]

It's a peer dependency of the grafana/eslint-config.