[loki-distributed] Add sidecar container for loki ruler to fetch AlertingRules from Configmaps/Secrets #2900
+406
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igmaps/Secrets Signed-off-by: mbeczkowski <[email protected]>
|
|
zanhsieh
approved these changes
Jan 12, 2024
Footur
approved these changes
Jan 17, 2024
|
Hi guys, any news on this feature? |
|
@zalegrala Can you help with this PR please? |
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: mbec-printify <[email protected]>
|
@Sheikh-Abubaker Do you have permission to approve this PR? |
Yes I have, is this feature tested properly ? |
|
Can we somehow unblock this please? It's a pity that Loki supports pull based alerts but we need to patch things manually because of an open PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Already done in those 2 PRs for legacy repo & current loki Helm chart. I've migrated the above solution to the loki-distributed Helm chart and tested locally with prom-stack.
What this PR does:
PR adds a sidecar container to the Ruler deployment to fetch alerting rules defined in separate ConfigMaps and Secrets (based on k8s labels).
The goal of this update is to enable the creation of AlertingRules independently for other services deployments. With this setup, services can manage their own alerting rules in a self-contained manner, through individual ConfigMaps or Secrets, without directly interfacing with the primary ruler deployment.
Checklist