Add modules and auths key in snmp yml #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
This looks good to me.
I spent an unnecessarily long time looking at previous commits because.. I recall that we changed this already.
I know that the agent was updated to a new version of the SNMP exporter, which necessitated some changes to our config, which I was sure we (I?) did, but I can't find record of it.
Perhaps it was on the now defunct ubnt integration.
In any case, this looks good! Thanks for cleaning it up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://github.com/grafana/support-escalations/issues/8785
The default yml is referenced in the Ubiquiti edge router's integration instructions.
But the yml is in incorrect format and causes the agent to crash and not startup.
This PR adds the required keys in the yml file to fix the issue.