-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Modules
and JavaScript Compatibility Mode
docs
#1489
Conversation
99e231c
to
8467969
Compare
Modules
and JavaScript Compatibility Mode
docs
Modules
and JavaScript Compatibility Mode
docsModules
and JavaScript Compatibility Mode
docs
@mstoykov please, could you provide a technical review and share any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the next
files, I just left a few comments with some small edits to follow our style guide. It would be great to still get a technical review before we merge.
0794072
to
a6a2666
Compare
Suggestions from @heitortsergent are now included and ported to previous versions. Additionally, all the changes were ported to
cc @mstoykov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general
Left some comments around stuff that I think might be better
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
c747a8d
to
3ea11fe
Compare
Co-authored-by: Olha Yevtushenko <[email protected]>
@heitortsergent, I have addressed all the requests, and seems ready for the merge. |
What?
Using k6 / Modules
Sharing JavaScript modules
sectionUsing TypeScript
sectionExtension modules
Using k6 / JavaScript Compatibility Mode
Extensions / Build a k6 binary using Docker
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.