Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error handler example #1495

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Add Error handler example #1495

merged 6 commits into from
Feb 7, 2024

Conversation

ppcano
Copy link
Collaborator

@ppcano ppcano commented Jan 28, 2024

What?

Add Error handler example

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Related PR(s)/Issue(s)

Logging in k6

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some very minor edits, LGTM overall! 🚀

docs/sources/next/examples/error-handler.md Outdated Show resolved Hide resolved
docs/sources/next/examples/error-handler.md Outdated Show resolved Hide resolved
docs/sources/next/examples/error-handler.md Outdated Show resolved Hide resolved
docs/sources/next/examples/error-handler.md Outdated Show resolved Hide resolved
@heitortsergent
Copy link
Collaborator

Ah I forgot to add this to review @ppcano, can you add this update to v0.49 as well? Or if you want me to do it, just let me know. 🙇

@ppcano ppcano force-pushed the pepe/error-handler-example branch from a183193 to ee32bbc Compare February 7, 2024 10:29
@ppcano
Copy link
Collaborator Author

ppcano commented Feb 7, 2024

@heitortsergent, I ported the changes to v0.49 and applied your suggestions. This should now be ready. Please, go ahead and release it when appropriate.

@heitortsergent heitortsergent merged commit 6c8d3e9 into main Feb 7, 2024
6 checks passed
@heitortsergent heitortsergent deleted the pepe/error-handler-example branch February 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants