Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Async ElementHandle #1598

Merged
merged 40 commits into from
May 29, 2024
Merged

Update to Async ElementHandle #1598

merged 40 commits into from
May 29, 2024

Conversation

inancgumus
Copy link
Member

What?

Update relevant ElementHandle methods from sync to async.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

Updates: grafana/xk6-browser#1296

inancgumus added 30 commits May 22, 2024 14:55
@inancgumus
Async elementhandle.index
0a33452
@inancgumus
Async elementhandle.boundingbox
048deb8
@inancgumus
Async elementhandle.dblclick
c555738
@inancgumus
Async elementhandle.click
7949335
@inancgumus
Async elementhandle.isHidden
fd35ee3
@inancgumus
Async elementhandle.isVisible
3f63f1c
@inancgumus
Async elementhandle.isChecked
8f29d2e
@inancgumus
Async elementhandle.isDisabled
a9cffcf
@inancgumus
Async elementhandle.isEditable
df466dd
@inancgumus
Async elementhandle.isEnabled
2c8047f
@inancgumus
Async elementhandle.check
4911a4d
@inancgumus
Async elementhandle.uncheck
0f54891
@inancgumus
Async elementhandle.query
47b0806
@inancgumus
Async elementhandle.queryAll
7ef8a01
@inancgumus
Async elementhandle.tap
b5a0dc2
@inancgumus
Async elementhandle.contentFrame
3c987aa
@inancgumus
Async elementhandle.ownerFrame
2de12c1
@inancgumus
Async elementhandle.setInputFiles
a447d0e
@inancgumus
Async elementhandle.dispatchEvent
8e1237d
@inancgumus
Async elementhandle.fill
b04fb1b
@inancgumus
Async elementhandle.focus
0cf4a19
@inancgumus
Async elementhandle.hover
a59c094
@inancgumus
Async elementhandle.press
5621b93
@inancgumus
Async elementhandle.type
ed23586
@inancgumus
Async elementhandle.textContent
fd36306
@inancgumus
Async elementhandle.selectText
930b6d8
@inancgumus
Async elementhandle.selectOption
6d20b72
@inancgumus
Async elementhandle.screenshot
7c48be2
@inancgumus
Async elementhandle.getAttribute
986ee4c
@inancgumus
Async elementhandle.innerHTML
20bafe9
@inancgumus inancgumus added the Area: browser The browser module label May 22, 2024
@inancgumus inancgumus self-assigned this May 22, 2024
@inancgumus inancgumus marked this pull request as ready for review May 22, 2024 11:56
@inancgumus inancgumus requested review from ankur22, heitortsergent and allansson and removed request for heitortsergent May 22, 2024 11:56
@inancgumus inancgumus mentioned this pull request May 22, 2024
Closed
@inancgumus inancgumus removed the request for review from heitortsergent May 24, 2024 16:06
ankur22
ankur22 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I may have missed somethings though since there were a lot of changes.

I was able to catch something which need to be reviewed.

docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/dblclick.md Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/ishidden.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/isvisible.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/query.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/setinputfiles.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/dispatchevent.md Outdated Show resolved Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/waitforselector.md Show resolved Hide resolved
@inancgumus
Fix async elementhandle issues
e994ed8 
+ Remove options from locator.isHidden link
+ Remove options from locator.isVisible link
+ Update page.selector signature
+ Fix elementhandle.setInputFiles formatting
+ Fix locator.dispatchEvent link
+ Fix locator.waitFor notice
@inancgumus inancgumus requested a review from ankur22 May 28, 2024 13:30
@inancgumus
Copy link
Member Author

inancgumus commented May 28, 2024 •
edited
Loading

@ankur22

Nice work! I may have missed somethings though since there were a lot of changes.

Thanks! I've fixed what you could find here.

I've checked everything from scratch and found another issue: setInputFiles didn't have return header. Fixed c417818.

ankur22
ankur22 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

allansson
allansson approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@allansson allansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inancgumus inancgumus merged commit 85472da into main-browser-async May 29, 2024
2 checks passed
@inancgumus inancgumus deleted the async/elementhandle branch May 29, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allansson allansson allansson approved these changes

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
Area: browser The browser module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @ankur22 @allansson