-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import.meta.resolve documentation #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about ESLint configuration changes, but the rest looks good! 👍🏻
I left a couple of minor comments, but none is really blocking!
Co-authored-by: Joan López de la Franca Beltran <[email protected]>
I don't really like the current way of the dedupping that means that they are shared documents for all the versions and opted to not try to fix this given the time constraint. cc @heitortsergent - if you can point me how to reuse any file that will be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small edits, thanks for adding these changes in @mstoykov! 🙇
Also @mstoykov I didn't understand your comment about the shared documents for all the versions, could you please explain that to me? 🙏 We have this tutorial in the Writers' Toolkit about how to create shared content if that helps: https://grafana.com/docs/writers-toolkit/write/reuse-content/reuse-shared-content/ |
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
It seems I got confused by the way it is written and taught the shared files were under So it is all good ! Sorry for the confusion. |
I think the shared files can be in the |
I think in theory you can look up in either location. All the directories will be synced to the website repository and you can look up "unversioned" documentation by setting |
What?
Add documentation for grafana/k6#3873 and fix eslint to support it.
Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)