Update goja to latest master #1782
Conversation
| var o1 = MyObject(arg); // same thing | ||
| o instanceof MyObject && o1 instanceof MyObject; // true | ||
| ``` | ||
| In order to implement a constructor function in Go use `func (goja.ConstructorCall) *goja.Object`. |
There was a problem hiding this comment.
Hmm how does this affect our XConstructor magic?
There was a problem hiding this comment.
In no way ... as we are not using it
But also this seems as only a documentation chang
There was a problem hiding this comment.
But apparently there's a native way to do this in goja which we don't use. Should we open an issue to investigate this, given that this is the code above our code to do the same 😅 https://github.com/loadimpact/k6/blob/ccffbcaaddd7f2d472cdced0da847fde2140ef88/js/common/bridge.go#L257
There was a problem hiding this comment.
I don't think I will come to this until we decide to rewrite the bridge :D ... so if you think you will come to this refactoring work before that ... or think someone else will do it - open an issue ;)
The fixes for it are in the form of disabling all source map support as if it's missing the parsing will error out.
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
==========================================
- Coverage 71.46% 71.40% -0.06%
==========================================
Files 178 178
Lines 13777 13781 +4
==========================================
- Hits 9846 9841 -5
- Misses 3318 3325 +7
- Partials 613 615 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
It is only part of the blocker dop251/goja#227 |
No description provided.