Use golangci-lint action in github #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
reviewed
Feb 24, 2022
| golangci-lint run --out-format=tab --new-from-rev "$BASEREV" ./... | ||
| # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | ||
| version: v1.43 | ||
| only-new-issues: true |
There was a problem hiding this comment.
Ah, glad to see this works now. The reason we didn't use it before was that only-new-issues didn't work the same as --new-from-rev so it always showed old issues.
mstoykov
force-pushed
the
useGolangCILintAction
branch
from
dffbca7 to
809942f
Compare
olegbespalov
approved these changes
Feb 28, 2022
na--
approved these changes
Feb 28, 2022
|
@codebien unfortunately github interfaces no longer shows it - but I had commits which failed. As a side note it not only failed the step but made annotation, which is ... less spammy than comments but also arguably harder to notice so. But yeah it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.