Fix js lint #3393
Merged
Fix js lint #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3393 +/- ##
==========================================
+ Coverage 73.11% 73.13% +0.02%
==========================================
Files 258 258
Lines 19650 19648 -2
==========================================
+ Hits 14367 14370 +3
+ Misses 4401 4396 -5
Partials 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
codebien
reviewed
Oct 13, 2023
| @@ -241,7 +241,7 @@ func TestInitContextOpen(t *testing.T) { | |||
| {[]byte("hello world!"), "ascii", 12}, | |||
| {[]byte("?((¯°·._.• ţ€$ţɨɲǥ µɲɨȼ๏ď€ΣSЫ ɨɲ Ќ6 •._.·°¯))؟•"), "utf", 47}, | |||
| {[]byte{0o44, 226, 130, 172}, "utf-8", 2}, // $€ | |||
| //{[]byte{00, 36, 32, 127}, "utf-16", 2}, // $€ | |||
| // {[]byte{00, 36, 32, 127}, "utf-16", 2}, // $€ | |||
There was a problem hiding this comment.
Why do we want to keep it?
Suggested change
| // {[]byte{00, 36, 32, 127}, "utf-16", 2}, // $€ |
There was a problem hiding this comment.
I don't want to remove code that isn't absolutely dead in a lint fixing pass.
Maybe one day we will make this work 🤷
olegbespalov
previously approved these changes
Oct 13, 2023
olegbespalov
approved these changes
Oct 13, 2023
codebien
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix js package lint issues
Why?
Part of #linter issues #769
Checklist
make ci-like-lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)