js/k6/http: Fix lint errors #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
+ Coverage 72.82% 72.97% +0.14%
==========================================
Files 278 280 +2
Lines 20947 20951 +4
==========================================
+ Hits 15254 15288 +34
+ Misses 4715 4692 -23
+ Partials 978 971 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codebien
requested review from
mstoykov and
joanlopez
and removed request for
a team
mstoykov
reviewed
Jan 24, 2024
Comment on lines
+130
to
+134
| b, ok := resp.Body.([]byte) | ||
| if !ok { | ||
| panic("got an unexpected type for the response body, only []byte is accepted") | ||
| } | ||
| resp.Body = c.moduleInstance.vu.Runtime().NewArrayBuffer(b) |
There was a problem hiding this comment.
There really is no way for this to happen apart from programming error on our side.
I am not against hte change - but arguably:
- just a nolint would've been simpler
- this panic should mention this is a programming error.
mstoykov
approved these changes
Jan 24, 2024
joanlopez
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #769