Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudapi: lint fixes + just use crypto/rand #3627

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

What?

Some leftover lint fixes and just move to crypto/rand for the idempotency token.

Part of #769

Why?

Fixes lint issues

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Some leftover lint fixes and just move to crypto/rand for the idempotency
token.

Part of #769
@mstoykov mstoykov added this to the v0.51.0 milestone Mar 11, 2024
@mstoykov mstoykov requested a review from a team as a code owner March 11, 2024 08:59
@mstoykov mstoykov requested review from oleiade and olegbespalov and removed request for a team March 11, 2024 08:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (47c5bb0) to head (934d258).

❗ Current head 934d258 differs from pull request most recent head 3bb5dc2. Consider uploading reports for the commit 3bb5dc2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3627      +/-   ##
==========================================
- Coverage   73.57%   73.56%   -0.02%     
==========================================
  Files         277      277              
  Lines       20244    20243       -1     
==========================================
- Hits        14895    14892       -3     
- Misses       4401     4403       +2     
  Partials      948      948              
Flag Coverage Δ
macos ?
ubuntu 73.52% <ø> (-0.01%) ⬇️
windows 73.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit b80ad9f into master Apr 4, 2024
23 of 24 checks passed
@mstoykov mstoykov deleted the cloudApiFixes branch April 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants