Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors from newer versions of golangci-lint #3700

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

What?

The latest golangci-lint apparently enabled some more lint corner cases. So a bunch of things started complaining.

Most of it is unused parameters

Why?

Part of #769

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.51.0 milestone Apr 22, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 22, 2024 08:43
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 22, 2024 08:43
oleiade
oleiade previously approved these changes Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 73.26%. Comparing base (edd2d15) to head (bb64743).
Report is 1 commits behind head on master.

❗ Current head bb64743 differs from pull request most recent head 4b7097e. Consider uploading reports for the commit 4b7097e to get more accurate results

Files Patch % Lines
cmd/login_influxdb.go 0.00% 1 Missing and 1 partial ⚠️
cmd/outputs.go 0.00% 1 Missing and 1 partial ⚠️
api/server.go 50.00% 0 Missing and 1 partial ⚠️
cmd/login.go 0.00% 0 Missing and 1 partial ⚠️
cmd/login_cloud.go 0.00% 0 Missing and 1 partial ⚠️
cmd/pause.go 0.00% 0 Missing and 1 partial ⚠️
cmd/resume.go 0.00% 0 Missing and 1 partial ⚠️
cmd/stats.go 0.00% 0 Missing and 1 partial ⚠️
cmd/status.go 0.00% 0 Missing and 1 partial ⚠️
js/compiler/compiler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3700   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         276      276           
  Lines       20333    20333           
=======================================
  Hits        14897    14897           
  Misses       4486     4486           
  Partials      950      950           
Flag Coverage Δ
ubuntu 73.26% <29.41%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov requested a review from oleiade April 22, 2024 12:54
@mstoykov mstoykov merged commit d7b37b3 into master Apr 23, 2024
22 checks passed
@mstoykov mstoykov deleted the lintFixes branch April 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants