Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loki-stack cannot be used as a datasource for external grafana installs #2186

Closed
gclawes opened this issue Jun 4, 2020 · 4 comments · Fixed by #2197
Closed

loki-stack cannot be used as a datasource for external grafana installs #2186

gclawes opened this issue Jun 4, 2020 · 4 comments · Fixed by #2197
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us!

Comments

@gclawes
Copy link

gclawes commented Jun 4, 2020

Describe the bug
After PR #2086, loki-stack can no longer be used to install loki as a datasource for other grafana installations, such as from prometheus-operator.

To Reproduce
Steps to reproduce the behavior:

  1. Install prometheus-operator with grafana installed
  2. Install loki-stack with grafana disabled
  3. Query: {} term

Expected behavior
I would expect the grafana datasource configmap to be usable when installing grafana with methods other than loki-stack.

Environment:

  • Infrastructure: k3s
  • Deployment tool: helm
@gclawes gclawes mentioned this issue Jun 4, 2020
Merged
@cyriltovena
Copy link
Contributor

cyriltovena commented Jun 5, 2020 •
edited
Loading

Yes good catch, my suggestions is: let’s add an another setting (bool) to force it. Easy enough.

@cyriltovena cyriltovena added component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! labels Jun 5, 2020
@gclawes
Copy link
Author

gclawes commented Jun 5, 2020

Why not just revert it to the original setting? If you want both enabled, just toggle both bools?

@cyriltovena
Copy link
Contributor

Yeah that works too.

@gclawes
Copy link
Author

gclawes commented Jun 5, 2020

I think that's the way to go, reduce unnecessary logic.

@cyriltovena cyriltovena mentioned this issue Jun 8, 2020
Closed
cyriltovena added a commit to cyriltovena/loki that referenced this issue Jun 8, 2020
@cyriltovena
Render loki datasources even if Grafana is disabled.
7f1df27 
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes grafana#2186
Fixes grafana#2195

Now regarding grafana#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <[email protected]>
@cyriltovena cyriltovena mentioned this issue Jun 8, 2020
Merged
cyriltovena added a commit that referenced this issue Jun 22, 2020
@cyriltovena
Render loki datasources even if Grafana is disabled. (#2197)
54a9e67 
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes #2186
Fixes #2195

Now regarding #2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
@cyriltovena
Render loki datasources even if Grafana is disabled. (grafana#2197)
524f390 
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes grafana#2186
Fixes grafana#2195

Now regarding grafana#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render loki datasources even if Grafana is disabled. cyriltovena/loki
2 participants
@gclawes @cyriltovena