-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki Canary add insecure option #4366
Comments
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
This is pretty important, I would like to see this implemented |
**What this PR does / why we need it**: This change allows client certificates signed by a self-signed certificate authority to be used by the Loki canary. **Which issue(s) this PR fixes**: Fixes #4366 **Special notes for your reviewer**: This has been tested on linux amd64 with self-signed certificates. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
**What this PR does / why we need it**: This change allows client certificates signed by a self-signed certificate authority to be used by the Loki canary. **Which issue(s) this PR fixes**: Fixes grafana#4366 **Special notes for your reviewer**: This has been tested on linux amd64 with self-signed certificates. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
**What this PR does / why we need it**: This change allows client certificates signed by a self-signed certificate authority to be used by the Loki canary. **Which issue(s) this PR fixes**: Fixes grafana#4366 **Special notes for your reviewer**: This has been tested on linux amd64 with self-signed certificates. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
**What this PR does / why we need it**: This change allows client certificates signed by a self-signed certificate authority to be used by the Loki canary. **Which issue(s) this PR fixes**: Fixes grafana#4366 **Special notes for your reviewer**: This has been tested on linux amd64 with self-signed certificates. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
First of all, thank you for your work !
Is your feature request related to a problem? Please describe.
I try to use Loki Canary and I get a connection error because the certificate used is self-signed :
Describe the solution you'd like
It would be great to have a
-insecure
or-tls-skip-verify
option to bypass this error like inlogcli
.Describe alternatives you've considered
I thought of using HTTP, instead of HTTPS, for the query-frontend but since Loki Canary and Promtail will be placed on another machine, it is important that the request is encrypted.
The text was updated successfully, but these errors were encountered: