Helm: Fix the reference error of loki/loki helm chart #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new valuable "client.name" instead of "promtail.name"
polar3130
changed the title
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* fix a reference error of loki/loki helm chart add new valuable "client.name" instead of "promtail.name" * bump loki-stack chart * Add missing chart version Co-authored-by: cyriltovena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the reference error in loki/loki helm chart caused by undeclarated variable "promtail.name".
Instead of declare the variable "promtail.name", I propose that add new variable "client.name" ( for Loki, clients are not always Promtail ).
Which issue(s) this PR fixes:
Fixes #878
Special notes for your reviewer:
Checklist