-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation on how to use otel collector for ingesting logs to loki #11026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Nice job!
To start ingesting logs in OpenTelemetry format, you need to enable `allow_structured_metadata` per tenant configuration (in the `limits_config`). | ||
|
||
## Configure the OpenTelemetry Collector to write logs into Loki | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an introductory sentence or two to explain that the following edits are made in the collector config file. It probably wouldn't hurt to drop in a link to https://opentelemetry.io/docs/collector/configuration/.
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Just a couple more suggestions, but LGTM. Nice work!
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 few minor clarifications
|
||
Loki does not support `.` or any other special characters other than `_` in label names. The unsupported characters are replace with an `_`. | ||
|
||
For example, `service.name` in OTLP would become `service_name` in Loki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies also when querying it back I guess? Meaning you can only query with service_name
and not service.name
. Is it worth mentioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, will update the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler @sandeepsukhani a nit, do we want to call out on this page that support this experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevendungan It already has a note that it's experimental. Was there something more you wanted done? Or was there another page you meant to link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh, never mind, I just realized this comment WAS on a specific page. 😛 I think we're fine. Users cannot configure OTEL without going to the page that has the experimental note on it.
…loki (grafana#11026) **What this PR does / why we need it**: In PR grafana#10727, we added support for ingesting logs to loki in OTLP format. This PR adds the documentation on how to configure otel collector and how the data is mapped from OTLP format to Loki format. **Checklist** - [x] Documentation added --------- Co-authored-by: J Stickler <[email protected]>
What this PR does / why we need it:
In PR #10727, we added support for ingesting logs to loki in OTLP format. This PR adds the documentation on how to configure otel collector and how the data is mapped from OTLP format to Loki format.
Checklist