loki-stack: Add release name to prometheus service name. #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the prometheus service name was hard-coded to
prometheus-server
which would cause a conflict if attempting tohelm install
more than one release or namespace. For exampleWould result in
This PR incorporates the
{{ .Release.Name }}
into the service name to make it consistent with other generated names.Note that the
prometheus.fullname
template defined in_helpers.tpl
is named specifically to override the one defined by the normal prometheus chart. This allows the prometheus chart and templates in loki-stack to use the same logic for getting the prometheus service name.Which issue(s) this PR fixes:
Fixes #1169
Special notes for your reviewer:
Checklist