Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentd: Suppress unread configuration warning #1242

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

tarokkk
Copy link
Contributor

@tarokkk tarokkk commented Nov 8, 2019

What this PR does / why we need it:
This PR is to resolve fluentd warning for <label> configuration.

2019-11-08 13:29:55 +0000 [warn]: section <label> is not used in <match **> of loki plugin
2019-11-08 13:29:55 +0000 [warn]: section <label> is not used in <match **> of loki plugin
2019-11-08 13:29:55 +0000 [warn]: section <label> is not used in <match **> of loki plugin
2019-11-08 13:29:55 +0000 [warn]: section <label> is not used in <match **> of loki plugin

With the fix it should disappear

+1 Fix mandatory client cert configuration

Checklist

  • Documentation added
  • Tests updated

@tarokkk tarokkk changed the title Suppress unread configuration warning fluentd: Suppress unread configuration warning Nov 9, 2019
@tarokkk
Copy link
Contributor Author

tarokkk commented Nov 9, 2019

@cyriltovena please take a look

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyriltovena cyriltovena merged commit 3787596 into grafana:master Nov 11, 2019
@cyriltovena
Copy link
Contributor

I'll push the fix today.

@cyriltovena
Copy link
Contributor

@tarokkk pushed the new gems, thanks for that, do you want to join the loki team to take care of those PR on fluentd, if yes I'm happy to suggest you.

I realized I'm not doing a good job for them, specially testing wise because I don't use it.

@tarokkk
Copy link
Contributor Author

tarokkk commented Nov 12, 2019

Yeah sure, I'm happy to help

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
v10 schema builds on v9 but shards index rows to break up very big rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants