Tenant metrics #135
Tenant metrics #135
Conversation
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
pkg/distributor/distributor.go
Outdated
| Namespace: "loki", | ||
| Name: "distributor_bytes_received_total", | ||
| Help: "The total number of uncompressed bytes received per user", | ||
| }, []string{"org"}) |
There was a problem hiding this comment.
In cortex we used "user"[0]; in Loki we seem to be converging on the terms "instance" and "tenant".
[0] https://github.com/cortexproject/cortex/blob/master/pkg/distributor/distributor.go#L50
There was a problem hiding this comment.
Should I just run with tenant then? See: #131
There was a problem hiding this comment.
Instance is preferred I'd say; tenant is used in docs/presentations, but thats about it.
Signed-off-by: Goutham Veeramachaneni <[email protected]>
|
@tomwilkie PTAL |
|
shouldn't be |
|
You could move the metrics to func sendSamplesErr. One advantage would be there is already a loop over streams and you can use ingester.Addr |
|
Ah, we want to track the lines ingested per user and not per ingester. And when Prometheus scrapes these metrics, it automatically adds the ingester address as a labels so we can see how much each ingester is getting too. |
Usage has been removed as part of perf-optimisation: cortexproject/cortex@3006e39#diff-180f56d9aaf5a9aa079e6fc9cfcf1bc8L365 Signed-off-by: Goutham Veeramachaneni <[email protected]>
[release-5.5] Backport PR grafana#9433
Added the easiest write metrics for #103