Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the helm ci (backport helm-chart-weekly-6.19.0-weekly.227) #14805

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 7, 2024

Backport 5cf1938 from #14804


What this PR does / why we need it:

Fixes the helm-ci workflow, which is currently blocking all helm PRs and releases.

Which issue(s) this PR fixes:
Fixes #14799

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

(cherry picked from commit 5cf1938)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 7, 2024 00:21
@loki-gh-app loki-gh-app bot added backport size/XS type/bug Somehing is not working as expected type/ci labels Nov 7, 2024
@loki-gh-app loki-gh-app bot requested a review from trevorwhitney November 7, 2024 00:21

This comment has been minimized.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/loki-canary/daemonset.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:04.567633648 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:06.915655219 +0000
***************
*** 38,44 ****
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80
--- 38,44 ----
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227-4309f47
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/loki-canary/daemonset.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:04.659634493 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:07.011656101 +0000
***************
*** 38,44 ****
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80
--- 38,44 ----
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227-4309f47
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/loki-canary/daemonset.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:04.755635376 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:07.107656983 +0000
***************
*** 38,44 ****
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80
--- 38,44 ----
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227-4309f47
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/loki-canary/daemonset.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:04.859636330 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:07.207657901 +0000
***************
*** 38,44 ****
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80
--- 38,44 ----
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227-4309f47
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-gateway.default.svc.cluster.local.:80

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 2, Removed: 0)

Summary:

  • Added: 0

  • Modified: 2

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/loki-canary/daemonset.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:04.967637323 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/loki-canary/daemonset.yaml	2024-11-07 17:04:07.319658930 +0000
***************
*** 38,44 ****
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-enterprise-logs-gateway.default.svc.cluster.local.:80
--- 38,44 ----
 runAsUser: 10001
 containers:
 - name: loki-canary
! image: docker.io/grafana/loki-canary:k227-4309f47
 imagePullPolicy: IfNotPresent
 args:
 - -addr=loki-test-chart-name-enterprise-logs-gateway.default.svc.cluster.local.:80
loki/templates/provisioner/job-provisioner.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/provisioner/job-provisioner.yaml	2024-11-07 17:04:04.967637323 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/provisioner/job-provisioner.yaml	2024-11-07 17:04:07.319658930 +0000
***************
*** 36,42 ****
 runAsUser: 10001
 initContainers:
 - name: provisioner
! image: docker.io/grafana/enterprise-logs-provisioner:latest
 imagePullPolicy: IfNotPresent
 command:
 - /bin/sh
--- 36,42 ----
 runAsUser: 10001
 initContainers:
 - name: provisioner
! image: docker.io/grafana/enterprise-logs-provisioner:weekly-k227-a5ee5f0
 imagePullPolicy: IfNotPresent
 command:
 - /bin/sh

Removed Files

No removed files

@trevorwhitney trevorwhitney merged commit 5525f0d into helm-chart-weekly-6.19.0-weekly.227 Nov 7, 2024
62 checks passed
@trevorwhitney trevorwhitney deleted the backport-14804-to-helm-chart-weekly-6.19.0-weekly.227 branch November 7, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm backport size/S type/bug Somehing is not working as expected type/ci type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant