Loki: Use a new context to update the ring state after a failed chunk transfer #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 61.23% 61.23% -0.01%
==========================================
Files 158 158
Lines 12798 12803 +5
==========================================
+ Hits 7837 7840 +3
- Misses 4366 4368 +2
Partials 595 595
|
cyriltovena
reviewed
Jul 9, 2020
cyriltovena
reviewed
Jul 9, 2020
Co-authored-by: Cyril Tovena <[email protected]>
Co-authored-by: Cyril Tovena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the GRPC stream context was used to update the ring state back to PENDING after a failed chunk transfer.
However if the transfer failed because of a GRPC error this context would get canceled and this would prevent Loki from updating the ring state and it would force an os.Exit
This change uses a new context to update the ring state after a failed transfer to avoid this issue and also makes the error message more clear to explain why the loki process exits.