Logstash cpu usage fix #2607
Merged
Logstash cpu usage fix #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
cyriltovena
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Shame on me I didn't review this before.
LGTM Thank you @adityacs
stale
bot
removed
the
stale
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
* Replace concurrent-ruby-edge with agent lib * Fix logstash cpu consumption * increment gemspec version * increment gemspec version * fix tests Signed-off-by: Cyril Tovena <[email protected]>
|
Is there an estimation when new version of |
|
I just did sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes unnecessary cpu usage by logstash. This is happening because
loop selectis expected to block on multiple channels and not just run theloopindefinitely. Looks likeconcurrent-rubylibrary is not handling this. Also, tried agent but even this library is not handling channel block and receive as expected. So, changed the implementation to handle concurrency using just Ruby Threads.Which issue(s) this PR fixes:
Fixes #2551
After the initial startup, CPU usage is minimal