Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk schema v3 #2934

Merged
merged 1 commit into from
Nov 17, 2020
Merged

chunk schema v3 #2934

merged 1 commit into from
Nov 17, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 13, 2020

Adds a new default chunk schema (v3) which encodes uncompressed byte count by default in blocks. This will ensure compression ratios are reported correctly after chunk transfers or WAL replays. Also adds testware to guarantee blocks are entirely {de,}serialized in an extensible way.

@slim-bean slim-bean self-assigned this Nov 17, 2020
@slim-bean slim-bean added this to the 2.2 milestone Nov 17, 2020
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d merged commit 663c872 into grafana:master Nov 17, 2020
slim-bean added a commit that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants