Test label filter for bytes. #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Adds a new test to `ast_test` for filtering by bytes.| - Test another case than `B`.
cyriltovena
reviewed
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2941 +/- ##
==========================================
+ Coverage 61.75% 61.84% +0.09%
==========================================
Files 182 182
Lines 14863 14863
==========================================
+ Hits 9178 9192 +14
+ Misses 4839 4824 -15
- Partials 846 847 +1
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Initial version. Signed-off-by: Peter Štibraný <[email protected]> * Move PromQL API error translation to querier registration. Signed-off-by: Peter Štibraný <[email protected]> * Remove extra use of promql.ErrStorage. All unknown errors are translated to promql.ErrStorage already at API level of the querier. Signed-off-by: Peter Štibraný <[email protected]> * Updated CHANGELOG.md entry. Signed-off-by: Peter Štibraný <[email protected]> * Treat context.Canceled as user error and return 422. Signed-off-by: Peter Štibraný <[email protected]> * Added test for context.DeadlineExceeded. Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ast_testfor filtering by bytes.|B.