Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unwrap expressions from last optimization. #3194

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena [email protected]

@codecov-io
Copy link

Codecov Report

Merging #3194 (be01439) into master (070246c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
- Coverage   63.21%   63.17%   -0.05%     
==========================================
  Files         195      195              
  Lines       16566    16567       +1     
==========================================
- Hits        10473    10467       -6     
- Misses       5142     5152      +10     
+ Partials      951      948       -3     
Impacted Files Coverage Δ
pkg/logql/log/metrics_extraction.go 84.21% <100.00%> (+0.16%) ⬆️
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.89% <0.00%> (+2.06%) ⬆️
pkg/logql/log/parser.go 76.19% <0.00%> (+2.38%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 5eee25b into grafana:master Jan 20, 2021
slim-bean pushed a commit that referenced this pull request Jan 20, 2021
Signed-off-by: Cyril Tovena <[email protected]>
(cherry picked from commit 5eee25b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants