Properly release the ticker in Loki client. #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was only impacting the docker driver who would start/stop for each new followed containers. My assumption is that this would slowly build up and eat CPU over time. Fixes grafana#3319 I arrived to this conclusion since strace was showing a crazy amount of futex syscall and nothing else seems to be the cause. :pray: Signed-off-by: Cyril Tovena <[email protected]>
owen-d
approved these changes
Mar 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 63.18% 63.10% -0.09%
==========================================
Files 206 206
Lines 17737 17738 +1
==========================================
- Hits 11208 11194 -14
- Misses 5531 5544 +13
- Partials 998 1000 +2
|
slim-bean
pushed a commit
that referenced
this pull request
Apr 6, 2021
I think this was only impacting the docker driver who would start/stop for each new followed containers. My assumption is that this would slowly build up and eat CPU over time. Fixes #3319 I arrived to this conclusion since strace was showing a crazy amount of futex syscall and nothing else seems to be the cause. :pray: Signed-off-by: Cyril Tovena <[email protected]> (cherry picked from commit ecca5d3)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was only impacting the docker driver who would start/stop for each new followed containers.
My assumption is that this would slowly build up and eat CPU over time.
Fixes #3319
I arrived to this conclusion since strace was showing a crazy amount of futex syscall and nothing else seems to be the cause.
🙏
big thanks to @glebsam @till
Signed-off-by: Cyril Tovena [email protected]