Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retention doc #3775
Retention doc #3775
Changes from 2 commits
aca7bf8
36bdc1e
aac61d1
0c04077
6d75a96
33255cb
b442038
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For lines 36 thru 42, why does the reader of the Loki docs need to know this info? It feels like the internals of implementation to me.
Also, if the user configures this, when would #2 ever occur or be relevant? Do users have a way of knowing if there were chunks mistakenly marked for deletion? Another issue: if a mistake was made, how would the user cancel chunk deletion? That is not specified here. Are the marker files visible to the user? How does the user identify the disk to use for marker files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to explain why
retention_delete_delay
exist and how it should be configured.Setting a too low delay could lead to unexpected behaviour. The default is 2h and I don't think it should ever be lower. Maybe we should leave it to that, since we don't yet have a way to rebuild back the index.
As for 2, someone could have made a wrong configuration, and the compactor could have ran, it's not easy to rebuild the index (we don't have out of the box solution) but if they ever had any super important data, it's not deleted. To cancel the deletion you just need to delete the marker files generated, they are store on the disk of their choice using
working_directory
. I think we should skip this part.WDYT ? I still want to express why there's a
retention_delete_delay
and what it does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, let's fix some grammar, and consider in the future how to make this better. In the future, we should either explain how to cancel the deletion or provide a link within the docs to the place where it is explained.